Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
August 13, 2024 15:12
…ithub.com/SW-CSS/sw-css into Feature/#152-해커톤_페이지_구현
…ub.com/SW-CSS/sw-css into Feature/#152-해커톤_페이지_구현
…ub.com/SW-CSS/sw-css into Feature/#152-해커톤_페이지_구현
- 정보 유형을 상태로 관리하지 않고 별개의 페이지로 분리 #160
- 팀 Readme 불러오는 로직 구현 #160
added 7 commits
August 25, 2024 17:56
llddang
reviewed
Aug 26, 2024
Comment on lines
+8
to
+13
| const ReadmeViewer = ({ repoUrl }: ReadmeViewerProps) => { | ||
| const { data: readme, isPending, isError } = useGithubReadme(repoUrl); | ||
| if (isPending) return <div className="flex justify-center flex-grow items-center text-xl text-comment">README 문서를 불러오는 중입니다.</div>; | ||
| if(isError||!readme) return <div className="flex justify-center flex-grow items-center text-xl text-comment">README 문서를 불러오는 데 실패했습니다.</div>; | ||
| return <MarkdownViewer content={readme} />; | ||
| }; |
| @@ -29,7 +29,7 @@ function useDivSize(): [React.RefObject<HTMLDivElement>, ComponentSize] { | |||
| window.addEventListener('resize', handleResize); | |||
|
|
|||
| return () => window.removeEventListener('resize', handleResize); | |||
| }, []); | |||
| }, [componentRef.current?.getBoundingClientRect().top, componentRef.current?.getBoundingClientRect().left]); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
20분